Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This was referenced Sep 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #51411
Type of change
What does this PR do?
Uses the greater of the stored aggregate cursor and the latest persisted event sequence before assigning a local sequence. A stale cursor can no longer retry an already-written sequence forever. The owner-claim path is unchanged.
Running and comparing v1 and v2 is a normal plugin-development workflow. This is defensive recovery for an already damaged shared DB; it complements, rather than replaces, correct versioned data isolation.
How did you verify your code works?
bun test test/event.test.tsinpackages/core— 45 passed. The new regression first writes events 0 and 1, lowers only the cursor, then confirms a new event receives 2 and retains its owner.bun typecheckinpackages/core— passed.bunx oxlint packages/core/src/event.ts packages/core/test/event.test.ts— no errors.1.18.32created a session in an isolated shared DB, latestdevreopened it, and after lowering only that session cursor from 0 to -1, aresume:falseprompt was admitted at sequence 1. SQLite integrity check passed; both test servers were stopped.Screenshots / recordings
Not applicable.
Checklist