Repository navigation
Conversation
`write/edit`, `and/or` and similar prose shorthand were classified as paths by inlineCodeKind, rendering them as clickable file links that fail with 'File not found' on click. Only treat slash tokens as paths with explicit signals: ./, ~/, absolute, drive-letter, @scope/, trailing separator, depth > 2, or file-ish characters in a two-segment pair.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This was referenced Sep 28, 2026
|
Bare Head Fork leaf kvnloo#195 recorded fail→pass on That locks the bare word/word case. It does not reclassify real paths. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #51723
Type of change
What does this PR do?
inlineCodeKindtreated any slash-containing inline code as a file path, so prose shorthand likewrite/editrendered as a clickable file link that fails with 'File not found' on click. Slash tokens now need an explicit path signal (./, ~/, absolute, drive-letter, @scope/, trailing separator, depth > 2, or file-ish characters in a two-segment pair) to count as paths.Examples (before -> after):
write/edit,and/or,input/output,TCP/UDP,24/7session/statuspackages/desktop-electron,release/v1.2.3packages/app/src,./scripts/setup,~/x,C:\Users\xapp.tsx,SKILL.md,DockerfileKnown trade-off: plain two-segment dirs like
src/componentsalso stop linking (structurally identical to prose shorthand, can't have both with a regex). Verified the change is strictly un-linking: across a 94-token corpus, every behavior delta is path -> plain, zero new links created.How did you verify your code works?
Ran the real suite with bun in packages/session-ui: 4 pass, 0 fail (43 expects). Also ran an old-vs-new differential of the actual functions over 104 tokens (paths, prose, URLs, edge cases): 43 deltas, all strictly path -> plain, zero new links created.
Screenshots / recordings
N/A — classification-only change; the bug repro is in #51723.
Checklist