Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Refs #36677
This PR covers the active-borrower reload lifecycle leak discussed in that issue. It does not establish that the original idle CPU loop or accumulated MCP processes are resolved.
Type of change
What does this PR do?
Fix the active-borrower reload leak described by Just-Silver and underdark456. After reload replaces an RcMap entry under the same key, the old entry sees the replacement and treats itself as cached. With an infinite idle TTL, its layer scope never closes.
Patch Effect 4.0.0-rc.112 to compare entry identity when releasing: close the detached graph after its last borrower, without removing the replacement. The regression holds two borrowers across reload and checks both finalization and replacement reuse. This fixes that lifecycle leak; I have not reproduced the original idle CPU loop or measured the reported MCP process counts.
How did you verify your code works?
bun run test test/location-layer.test.ts --timeout 60000: 25 passed. The initial default-timeout run had 22 passes and 3 five-second timeouts.bun run checkpassed through the normal pre-push hook: lint reported 0 errors (17,479 existing warnings); all 36 typecheck tasks passed. Node type stripping, disabled Astro telemetry, and a writable Wrangler log path were used for the local environment.Screenshots / recordings
Not applicable.
Checklist