Skip to content

feat(template): support object style templates - #34

Merged
antfu merged 6 commits into
antfu:mainfrom
jd-solanki:main
Jun 30, 2023
Merged

feat(template): support object style templates#34
antfu merged 6 commits into
antfu:mainfrom
jd-solanki:main

Conversation

@jd-solanki

Copy link
Copy Markdown
Contributor

Description

We already have template function but we can't name the template variables for readability.

Linked Issues

N/A

Additional context

Thanks for this package ❤️

@antfu

antfu commented Jun 28, 2023

Copy link
Copy Markdown
Owner

Maybe we could override the template?

@jd-solanki

Copy link
Copy Markdown
Contributor Author

You mean, removing existing implementation? I wanted that 😅 but it might break your other package so I created new one.

Do you want to replace the existing template function with this one? I'll be happy to do that.

@jd-solanki

Copy link
Copy Markdown
Contributor Author

Or you mean method & type overriding? Single function but does both 🤔

@antfu

antfu commented Jun 28, 2023

Copy link
Copy Markdown
Owner

Or you mean method & type overriding? Single function but does both 🤔

Yes :)

@jd-solanki

Copy link
Copy Markdown
Contributor Author

Or you mean method & type overriding? Single function but does both 🤔

Yes :)

ohk, I'll try to implement that 👍🏻

@jd-solanki
jd-solanki marked this pull request as draft June 28, 2023 11:02
@jd-solanki
jd-solanki marked this pull request as ready for review June 29, 2023 06:24
@antfu antfu changed the title feat(namedTemplate): new function feat(template): support object style templates Jun 30, 2023
@antfu
antfu merged commit c7bbe2d into antfu:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants