Avoid redundant Vulkan development packages in setup - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Vulkan v3.1.2 module bundles its C headers and Volk. Update the optional setup installer so Linux installs the C compiler, Vulkan loader, diagnostic tools, and a software ICD where available, without distribution Vulkan header or Volk development packages. Clarify the SDK role on macOS and Windows in the README and keep runtime warnings distinct from build readiness.
OpenCL still includes native
<CL/opencl.h>and requires native OpenCL development headers, so its setup script is unchanged.Verification
fmt -verify setup.vshpassed.run setup.vsh --checkpassed with the bundled 1.4.363 headers and system 1.3.275 runtime installed.setup.vsh --checkpassed unchanged.git diff --checkpassed.Package manager install commands are not executed in CI because they require privileged changes to the runner.