Skip to content

Fix deploy-site failure by removing broken fmin package-root import in Venn layout - #3888

Open
hustcc with Copilot wants to merge 4 commits into
masterfrom
copilot/fix-deploy-site-job
Open

hustcc with Copilot wants to merge 4 commits into
masterfrom
copilot/fix-deploy-site-job

Conversation

Copilot AI commented Sep 20, 2026 •

Copy link
Copy Markdown

The deploy-site GitHub Actions job failed during docs bundling because fmin resolved to a module with no named exports in that toolchain. Venn layout imported named symbols (bisect, zerosM, etc.) from fmin, causing webpack compile errors in site build.

  • Root cause addressed

    • Replaced Venn layout’s direct dependency on fmin package-root exports, which are not reliable in the deploy/docs bundling path.
  • Code changes

    • Added a local compatibility module at src/plots/venn/layout/fmin.ts implementing only the required helpers used by Venn layout:
      • bisect
      • zeros, zerosM
      • norm2, scale
      • conjugateGradient (with internal line search helpers)
    • Updated src/plots/venn/layout/layout.ts to import these helpers from ./fmin instead of fmin.
  • Behavioral scope

    • Change is isolated to Venn layout internals; public plot APIs and call sites remain unchanged.
    • Error handling in bisect now throws Error for consistent exception semantics.
// before
import { bisect, conjugateGradient, norm2, scale, zeros, zerosM } from 'fmin';

// after
import { bisect, conjugateGradient, norm2, scale, zeros, zerosM } from './fmin';

Copilot AI and others added 2 commits September 20, 2026 09:22
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job deploy-site Fix deploy-site failure by removing broken fmin package-root import in Venn layout Sep 20, 2026
Copilot AI requested a review from hustcc September 20, 2026 09:25
@hustcc
hustcc marked this pull request as ready for review September 20, 2026 09:46
@hustcc

hustcc commented Sep 20, 2026

Copy link
Copy Markdown
Member

Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>

Copilot AI commented Sep 20, 2026

Copy link
Copy Markdown
Author

@copilot 继续修复 ci https://github.com/antvis/G2Plot/actions/runs/35502196164/job/106058603366?pr=3888

已继续修复这个 CI 问题:src/plots/venn/layout/fmin.ts 中将未被重新赋值的 pk 从 let 改为 const,解决了 prefer-const 报错。修复提交:bfa9c92。

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants