Repository navigation
Conversation
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job deploy-site
Fix deploy-site failure by removing broken Sep 20, 2026
fmin package-root import in Venn layout
hustcc
marked this pull request as ready for review
September 20, 2026 09:46
Co-authored-by: hustcc <7856674+hustcc@users.noreply.github.com>
Author
已继续修复这个 CI 问题: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deploy-siteGitHub Actions job failed during docs bundling becausefminresolved to a module with no named exports in that toolchain. Venn layout imported named symbols (bisect,zerosM, etc.) fromfmin, causing webpack compile errors in site build.Root cause addressed
fminpackage-root exports, which are not reliable in the deploy/docs bundling path.Code changes
src/plots/venn/layout/fmin.tsimplementing only the required helpers used by Venn layout:bisectzeros,zerosMnorm2,scaleconjugateGradient(with internal line search helpers)src/plots/venn/layout/layout.tsto import these helpers from./fmininstead offmin.Behavioral scope
bisectnow throwsErrorfor consistent exception semantics.