Add conditional support for GIT_SYNC_USERNAME/GIT_SYNC_PASSWORD vs GITSYNC_USERNAME/GITSYNC_PASSWORD in Helm Chart

[kyungjunleeme]

See also: #43247. While not directly related, this issue shares a similar context.

Description

Problem

Currently, the Airflow Helm Chart expects Git Sync v4-style secrets (GITSYNC_USERNAME, GITSYNC_PASSWORD) regardless of the actual version of the Git Sync image used.

However, when using Git Sync v3 (e.g., dags.gitSync.image.tag: v3.6.9), the expected environment variables are:

• GIT_SYNC_USERNAME
• GIT_SYNC_PASSWORD

But the chart only renders the v4-style variables (GITSYNC_*), which results in errors or broken Git sync behavior for v3 users.

Proposal

Add logic in _helpers.yaml (or related templates) to:

• Detect Git Sync version via dags.gitSync.image.tag
• If v3: render

  - name: GIT_SYNC_USERNAME
    ...
  - name: GIT_SYNC_PASSWORD
    ...
  
  

Use case/motivation

No response

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[kyungjunleeme]

I’d like to take this on if the maintainers are open to the proposed changes.

[potiuk]

I’d like to take this on if the maintainers are open to the proposed changes.

sure

[kyungjunleeme]

@potiuk Thank you. Could you assign this issue to me?

[Miretpl]

This issue is duplicated by #56143, which has been resolved, and the change should be released with the next Helm Chart version - 1.19.0. The conclusions in both PRs (the one from #56245 and #52388) are a little different (the first treats the change as a simple bug fix, while the second treats it more like a breaking change). Personally, I'm closer to the second, but I'm not sure what should be done next:

1. Nothing
2. Adding a newsfragment to the currently merged change
3. Revert of the merged PR and new implementation, which is closer to the comments from feat(helm): Conditionally render GIT_SYNC_* vs GITSYNC_* env vars based on Git Sync version #52388 (new version field under images.gitSync section)

[Miretpl]

Pinging @romsharon98 @jedcunningham as you were involved in the mentioned PRs

[Miretpl]

Just to have it here too:

1. Chart: Fix gitsync version handling #61027 - discussion what to with Chart gitsync vars #56245
2. Revert "Chart gitsync vars (#56245)" #61098 - revert for Chart gitsync vars #56245

[potiuk]

@kyungjunleeme We are unassigning you from this issue as part of our updated assignment policy.

This is not meant to discourage your contribution — quite the opposite! You are still very welcome to work on this issue and submit a PR for it. Simply comment that you are working on it and open a PR when ready.

We found that formal assignments were not working well, as they often prevented others from contributing when the assignee was not actively working on the issue.