Fix task logs unavailable while waiting for retry - #63177
Closed
MonsterChenzhuo wants to merge 4 commits into
Closed
Fix task logs unavailable while waiting for retry#63177MonsterChenzhuo wants to merge 4 commits into
MonsterChenzhuo wants to merge 4 commits into
Conversation
Contributor
Author
|
The problem has been fixed.(#54547) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom Explanation
Task failure (Try 12) : The task attempt fails and the task instance transitions to UP_FOR_RETRY (waiting for the next retry).
Logs disappear : While the task instance is in UP_FOR_RETRY , Airflow treats it as neither “running” ( RUNNING ) nor “finished” (terminal states).
Brief description of the changes.
Fix an issue where task instance logs could become temporarily unavailable after a failed try when the task transitions to UP_FOR_RETRY (or UP_FOR_RESCHEDULE ).
In this window, the log endpoint could return only the “Log message source details” header without actual log content.
Update FileTaskHandler to also attempt fetching served logs from the worker log server for UP_FOR_RETRY / UP_FOR_RESCHEDULE states when no local or remote logs are found.
Why this change is needed.
UP_FOR_RETRY is treated as an “unfinished” state, so the existing logic did not fetch served logs (which was only done for RUNNING / DEFERRED or finished tasks), causing a gap where logs from the failed attempt were not accessible until the next try started.
What was changed.
In airflow-core/src/airflow/utils/log/file_task_handler.py , extend the condition that triggers reading served logs to include TaskInstanceState.UP_FOR_RETRY and TaskInstanceState.UP_FOR_RESCHEDULE .
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.