Fix remote task log pollution leaking out of S3 log handler test - #69539
Merged
vincbeck merged 1 commit intoJul 7, 2026
Merged
Conversation
test_read_remote_logs_with_real_s3_remote_log_io assigned _ActiveLoggingConfig.remote_task_log directly and never restored it, so any log-reading test collected afterwards tried to fetch logs from the long-gone mocked S3 bucket and failed with InvalidAccessKeyId.
jason810496
requested review from
Lee-W,
gopidesupavan,
jscheffl and
potiuk
and removed request for
jscheffl
July 7, 2026 11:28
vincbeck
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
test_read_remote_logs_with_real_s3_remote_log_ioassigns_ActiveLoggingConfig.remote_task_logdirectly and never restores it, so any log-reading test collected afterwards (e.g.test_log_reader.pywhen run aftertest_log_handlers.py) tries to fetch logs from the long-gone mocked S3 bucket and fails withInvalidAccessKeyId.What
_ActiveLoggingConfig.remote_task_logviamonkeypatch.setattrso it is restored after the test.Was generative AI tooling used to co-author this PR?