Clarify testing standard related to caplog assertions in AGENTS.md - #69803
Merged
amoghrajesh merged 2 commits intoJul 13, 2026
Conversation
amoghrajesh
requested review from
ashb,
choo121600,
jason810496,
jscheffl,
kaxil,
potiuk and
shahar1
as code owners
July 13, 2026 07:23
uranusjr
approved these changes
Jul 13, 2026
potiuk
approved these changes
Jul 13, 2026
amoghrajesh
requested review from
bugraoz93,
ephraimbuddy,
gopidesupavan,
jedcunningham and
vatsrahul1001
as code owners
July 13, 2026 08:27
vatsrahul1001
approved these changes
Jul 13, 2026
joshuabvarghese
pushed a commit
to joshuabvarghese/airflow
that referenced
this pull request
Jul 16, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
Related to #65421
On further investigation, I saw that the blanket "don't use caplog" rule predates the structlog migration.
caplog now resolves to cap_structlog under structlog, which supports safe structured assertions and only raw text matching is fragile and worth discouraging
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.