Skip to content

Clean up graph/grid UI - #69883

Merged
bbovenzi merged 1 commit into
apache:mainfrom
astronomer:fix-task-graph-icons
Jul 15, 2026
Merged

Clean up graph/grid UI#69883
bbovenzi merged 1 commit into
apache:mainfrom
astronomer:fix-task-graph-icons

Conversation

@bbovenzi

Copy link
Copy Markdown
Contributor

Cleaning up a few issues with the grid and graph views:

  1. Remove Preset Filters button from grid view.
  2. Remove keyboard icon from graph view. We don't use that anywhere else. Now we have the shortcut modal instead. (remove now-unused translation too)
  3. Make sure task group icon is consistent between graph and the side panel header
  4. Remove title from TaskName, it was redundant with tooltips
  5. Add extra space to getTextWidth calculation to make sure task nodes can render correctly with long names
Before After
Screenshot 2026-07-14 at 4 05 51 PM Screenshot 2026-07-14 at 4 01 20 PM
Screenshot 2026-07-14 at 4 06 07 PM Screenshot 2026-07-14 at 4 01 11 PM
Screenshot 2026-07-14 at 4 07 03 PM --

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat!

@bbovenzi
bbovenzi merged commit 707b1cc into apache:main Jul 15, 2026
88 checks passed
@bbovenzi
bbovenzi deleted the fix-task-graph-icons branch July 15, 2026 13:59
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-3-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 707b1cc v3-3-test

This should apply the commit to the v3-3-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

joshuabvarghese pushed a commit to joshuabvarghese/airflow that referenced this pull request Jul 16, 2026
bbovenzi added a commit that referenced this pull request Jul 16, 2026
* Add keyboard shortcut help dialog to discover available shortcuts (? key) (#68200)

* feat: keyboard shortcuts help dialog (press ?)

* remove unnecessary useCallback and useMemo hooks

* drop grid keyboard shortcut tooltip

* centralize shortcut definitions in a single catalog

* use nesting to reuse concept translation keys

* register code viewer fullscreen shortcut in the catalog

(cherry picked from commit 70bb308)

* [v3-3-test] Clean up graph/grid UI (#69883)

Backport of #69883 to v3-3-test. Applied on top of the #68200 backport,
so the only branch-specific adaptation is dropping the showPresetFilters
change to GridFilters.tsx — the Preset Filters feature (#68484) is not on
v3-3-test.

(cherry picked from commit 707b1cc)

---------

Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Aug 5, 2026
* Add keyboard shortcut help dialog to discover available shortcuts (? key) (#68200)

* feat: keyboard shortcuts help dialog (press ?)

* remove unnecessary useCallback and useMemo hooks

* drop grid keyboard shortcut tooltip

* centralize shortcut definitions in a single catalog

* use nesting to reuse concept translation keys

* register code viewer fullscreen shortcut in the catalog

(cherry picked from commit 70bb308)

* [v3-3-test] Clean up graph/grid UI (#69883)

Backport of #69883 to v3-3-test. Applied on top of the #68200 backport,
so the only branch-specific adaptation is dropping the showPresetFilters
change to GridFilters.tsx — the Preset Filters feature (#68484) is not on
v3-3-test.

(cherry picked from commit 707b1cc)

---------

Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants