Skip to content

Restore the lang-SDK Go bundle build - #70561

Merged
potiuk merged 1 commit into
mainfrom
tidy-go-example-after-grpc-bump
Jul 27, 2026
Merged

Restore the lang-SDK Go bundle build#70561
potiuk merged 1 commit into
mainfrom
tidy-go-example-after-grpc-bump

Conversation

@potiuk

@potiuk potiuk commented Jul 27, 2026

Copy link
Copy Markdown
Member

main is currently red on Kubernetes tests / K8S Lang-SDK for every PR, at the "Build Go bundle" step:

go: updates to go.mod needed; to update it:
	go mod tidy
lang-SDK provisioning failed in: Build Go bundle
subprocess.CalledProcessError: Command '['go', 'tool', 'airflow-go-pack', ...]' returned non-zero exit status 1.

kubernetes-tests/lang_sdk/go_example/ is a separate module that resolves the Go SDK from the in-repo sources:

replace github.com/apache/airflow/go-sdk => ../../../go-sdk

so it carries its own copy of the SDK's indirect requirements. #70226 bumped google.golang.org/grpc 1.79.3 → 1.82.1 inside /go-sdk only, leaving the example module pinned to the old versions. Go refuses to build an inconsistent module, so the job fails on every pull request rather than only on the one that did the bump.

This is go mod tidy in that module — the three indirect requirements realign with the SDK, plus go.sum:

-	google.golang.org/genproto/googleapis/rpc v0.0.0-20251202230838-ff82c1b0f217 // indirect
-	google.golang.org/grpc v1.79.3 // indirect
-	google.golang.org/protobuf v1.36.10 // indirect
+	google.golang.org/genproto/googleapis/rpc v0.0.0-20260414002931-afd174a4e478 // indirect
+	google.golang.org/grpc v1.82.1 // indirect
+	google.golang.org/protobuf v1.36.11 // indirect

Verified by running exactly what CI runs, in the example module:

$ go tool airflow-go-pack --output /tmp/lang_sdk_check .
Wrote bundle /tmp/lang_sdk_check (sdk=go/(devel), dags=1)

Worth a follow-up: nothing tidies the dependent module when Dependabot bumps a dependency in /go-sdk, so the next Go bump breaks this again the same way. A go mod tidy -diff check over the example module would catch it on the bump PR itself.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

The Go example bundle built by the lang-SDK Kubernetes test resolves the Go
SDK from the in-repo sources, so it carries its own copy of the SDK's
indirect requirements. Bumping a dependency inside go-sdk alone leaves the
two inconsistent, and Go then refuses to build the bundle at all, failing
the job on every pull request rather than only on the one that bumped it.

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@potiuk
potiuk merged commit 8db8d97 into main Jul 27, 2026
61 checks passed
@potiuk
potiuk deleted the tidy-go-example-after-grpc-bump branch July 27, 2026 21:12

@jason810496 jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank Jarek!

main is currently red on Kubernetes tests / K8S Lang-SDK for every PR, at the "Build Go bundle" step:

And sorry that I didn't notice the main is failing.

shahar1 pushed a commit to shahar1/airflow that referenced this pull request Jul 30, 2026
The Go example bundle built by the lang-SDK Kubernetes test resolves the Go
SDK from the in-repo sources, so it carries its own copy of the SDK's
indirect requirements. Bumping a dependency inside go-sdk alone leaves the
two inconsistent, and Go then refuses to build the bundle at all, failing
the job on every pull request rather than only on the one that bumped it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants