[v3-3-test] Fix the deadline_reference decorator's no-parentheses form (#70708) - #70966
Merged
Conversation
#70708) * Fix the deadline_reference decorator's no-parenthesis form Used bare, the decorator silently rebound the decorated class to the inner decorator function and skipped registration entirely, surfacing later as an unrelated TypeError with an unhelpful message. Accept both forms, add clearer error messaging when a reference cannot be instantiated, and clarify the related docs. * bugfix newsfragment * sphynx riddles (cherry picked from commit 8541668) Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
vatsrahul1001
marked this pull request as ready for review
August 3, 2026 08:43
vatsrahul1001
pushed a commit
that referenced
this pull request
Aug 5, 2026
#70708) (#70966) * Fix the deadline_reference decorator's no-parenthesis form Used bare, the decorator silently rebound the decorated class to the inner decorator function and skipped registration entirely, surfacing later as an unrelated TypeError with an unhelpful message. Accept both forms, add clearer error messaging when a reference cannot be instantiated, and clarify the related docs. * bugfix newsfragment * sphynx riddles (cherry picked from commit 8541668) Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used bare, the decorator silently rebound the decorated class to the inner decorator function and skipped registration entirely, surfacing later as an unrelated TypeError with an unhelpful message. Accept both forms, add clearer error messaging when a reference cannot be instantiated, and clarify the related docs.
bugfix newsfragment
sphynx riddles
(cherry picked from commit 8541668)
Co-authored-by: D. Ferruzzi ferruzzi@amazon.com