Skip to content

Walk each Dag once in DBDagBag.iter_all_latest_version_dags - #71500

Closed
Eason09053360 wants to merge 1 commit into
apache:mainfrom
Eason09053360:fix-dagbag-iter-latest-version-dags
Closed

Walk each Dag once in DBDagBag.iter_all_latest_version_dags#71500
Eason09053360 wants to merge 1 commit into
apache:mainfrom
Eason09053360:fix-dagbag-iter-latest-version-dags

Conversation

@Eason09053360

Copy link
Copy Markdown
Contributor

DBDagBag.iter_all_latest_version_dags() promises the latest version, but the
query returned every serialized_dag row, so a Dag was walked once per version
it had. Its one production caller is the FAB auth manager's Dag permission sync,
which therefore re-synced the same dag_id once per version.

Same origin and same fix as #70934: reuse the select that picks the highest
version_number per dag_id. That select is now used from a second module, so it
loses its leading underscore.

SerializedDagModel.read_all_dags() is not used here on purpose — it materialises
every Dag into a dict and ignores load_op_links, while this method is
deliberately a non-caching generator.

related: #70934


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

The method name promises the latest version, but the query returned every
serialized row, so the FAB auth manager re-synced permissions once per Dag
version.

related: apache#70934
@Eason09053360

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #70935, which fixes the same bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant