Walk each Dag once in DBDagBag.iter_all_latest_version_dags - #71500
Closed
Eason09053360 wants to merge 1 commit into
Closed
Walk each Dag once in DBDagBag.iter_all_latest_version_dags#71500Eason09053360 wants to merge 1 commit into
Eason09053360 wants to merge 1 commit into
Conversation
The method name promises the latest version, but the query returned every serialized row, so the FAB auth manager re-synced permissions once per Dag version. related: apache#70934
Contributor
Author
|
Closing as a duplicate of #70935, which fixes the same bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBDagBag.iter_all_latest_version_dags()promises the latest version, but thequery returned every
serialized_dagrow, so a Dag was walked once per versionit had. Its one production caller is the FAB auth manager's Dag permission sync,
which therefore re-synced the same dag_id once per version.
Same origin and same fix as #70934: reuse the select that picks the highest
version_numberper dag_id. That select is now used from a second module, so itloses its leading underscore.
SerializedDagModel.read_all_dags()is not used here on purpose — it materialisesevery Dag into a dict and ignores
load_op_links, while this method isdeliberately a non-caching generator.
related: #70934
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.