[AMORO-4290][AMS] Propagate internal Iceberg table commit failures - #4291
Merged
zhoujinsong merged 1 commit intoJul 27, 2026
Merged
Conversation
Log internal commit errors and propagate CommitFailedException to REST clients instead of swallowing failures. Add unit tests for failure propagation and metadata cleanup errors.
zhoujinsong
approved these changes
Jul 27, 2026
zhoujinsong
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #4290
Fix:
Propagate the failure as a CommitFailedException after best-effort metadata cleanup. The REST Catalog now returns HTTP 409, allowing Flink to detect the conflict and retry the commit.
The image is from my online production Kubernetes cluster, 409 error.
Data validation is fine.