Skip to content

WIP: Type checking with mypy#6301

Closed
xhochy wants to merge 1 commit into
apache:masterfrom
xhochy:mypy
Closed

WIP: Type checking with mypy#6301
xhochy wants to merge 1 commit into
apache:masterfrom
xhochy:mypy

Conversation

@xhochy

@xhochy xhochy commented Jan 28, 2020

Copy link
Copy Markdown
Member

First iteration to have type hints. I have found some problems using them, I'll adress those in separate PRs but I will leave the type hints itself here as an FYI and will rebase continuously until we have dropped Py2 so that we can use inline hints.

To make real use of mypy, we would need stubs for the Cython based modules, this depends on someone implementing a pyi generator for Cython, see also cython/cython#3150.

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@wesm

wesm commented Mar 19, 2020

Copy link
Copy Markdown
Member

Seems like rehabilitating this and adding mypy to our CI would be useful soon

@xhochy

xhochy commented Mar 19, 2020

Copy link
Copy Markdown
Member Author

My main issue holding this back is that I remember that we don't wanted to break 2.7 hard in the source code. Adding type hints and check to pyarrow would be much simpler when we could use 3.6+ syntax.

I'm still from time to time fixing bits that popped up during this work as separate PRs.

@nealrichardson

Copy link
Copy Markdown
Member

We did remove 2.7 support already, so maybe that's not a concern anymore?

@xhochy

xhochy commented Mar 23, 2020

Copy link
Copy Markdown
Member Author

Split this up and made a first round in #6676

@wesm

wesm commented May 24, 2020

Copy link
Copy Markdown
Member

Closing this since the work is being divided into separate PRs

@wesm wesm closed this May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants