Skip to content

ARROW-9390: [C++][Followup] Add underscores to is* string functions - #7764

Closed
wesm wants to merge 2 commits into
apache:masterfrom
wesm:cpp-compute-more-renaming
Closed

ARROW-9390: [C++][Followup] Add underscores to is* string functions#7764
wesm wants to merge 2 commits into
apache:masterfrom
wesm:cpp-compute-more-renaming

Conversation

@wesm

@wesm wesm commented Jul 14, 2020

Copy link
Copy Markdown
Member

No description provided.

@wesm

wesm commented Jul 14, 2020

Copy link
Copy Markdown
Member Author

cc @nealrichardson

@github-actions

Copy link
Copy Markdown

@nealrichardson nealrichardson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a typo in a comment but code LGTM, thanks!

Comment thread cpp/src/arrow/compute/kernels/scalar_string.cc Outdated
@wesm wesm closed this in f131fe6 Jul 14, 2020
@wesm
wesm deleted the cpp-compute-more-renaming branch July 14, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants