Skip to content

ARROW-9608: [Rust] Leaner feature gating for arrow in parquet #7873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vertexclique wants to merge 1 commit into from
Closed

ARROW-9608: [Rust] Leaner feature gating for arrow in parquet #7873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions rust/parquet/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ lz4 = { version = "1.23", optional = true }
zstd = { version = "0.5", optional = true }
chrono = "0.4"
num-bigint = "0.3"
arrow = { path = "../arrow", version = "2.0.0-SNAPSHOT", optional = true }
arrow = { path = "../arrow", version = "2.0.0-SNAPSHOT", optional = true, default-features = false }
serde_json = { version = "1.0", features = ["preserve_order"] }

[dev-dependencies]
Expand All @@ -49,7 +49,6 @@ brotli = "3.3"
flate2 = "1.0"
lz4 = "1.23"
zstd = "0.5"
arrow = { path = "../arrow", version = "2.0.0-SNAPSHOT" }

@sunchao sunchao Jul 31, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, does this mean we're removing arrow dependency from tests as well?

@vertexclique vertexclique Aug 1, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, because it is already a dependency in arrow.rs, using super::*; export in test modules will make it use the actual dependency exports of the arrow (which has been done already seems like). Tests had passed locally with no change and it passed here. I see it as good improvement tbh :)


[features]
default = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd"]