ARROW-10861: [Python] Update minimal NumPy version to 1.16.6#8878
ARROW-10861: [Python] Update minimal NumPy version to 1.16.6#8878xhochy wants to merge 2 commits into
Conversation
|
@github-actions crossbow submit -g wheel |
|
Revision: ab43613e8c91eb50998ac42a8fa356d76f98e3b1 Submitted crossbow builds: ursa-labs/crossbow @ actions-756
|
|
It seems that we can't use |
|
Windows Wheels in general are currently broken. I have a WIP PR in #8881 to have everything build from |
|
I have no problem with this PR, but it needs rebasing and fixing conflicts. |
|
@xhochy do we still want to do this for pyarrow 3.0 ? |
|
Oh yes, definitely! |
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
|
@github-actions crossbow submit -g wheel |
|
Revision: 4fe319c Submitted crossbow builds: ursa-labs/crossbow @ actions-875
|
| numpy==1.16.0; python_version == "3.7" | ||
| numpy==1.17.3; python_version == "3.8" | ||
| numpy==1.19.3; python_version >= "3.9" | ||
| numpy==1.19.4 |
There was a problem hiding this comment.
@xhochy shouldn't we test with 1.16.6 for python < 3.9 instead?
There was a problem hiding this comment.
We should test with the numpy release we have built with and a much newer one to detect issues. Currently we only test with one and there I would prefer to test with a newer release as this has a higher chance to fail on the C-API level like we have seen with the 1.20 release candidate.
|
The travis builds are still pending but it shouldn't affect them, so merging. |
No description provided.