Skip to content

EndpointRegistry tests - #118

Merged
orpiske merged 3 commits into
apache:mainfrom
orpiske:added-endpoint-tests
May 23, 2023
Merged

EndpointRegistry tests#118
orpiske merged 3 commits into
apache:mainfrom
orpiske:added-endpoint-tests

Conversation

@orpiske

@orpiske orpiske commented May 22, 2023

Copy link
Copy Markdown
Contributor

No description provided.

orpiske added 2 commits May 22, 2023 14:11
…quired to create an endpoint

This test computes the accumulated time of all the operations required to create a given number of routes (500, in this test).
…quired to resolve an endpoint

his test computes the accumulated time of all the operations required to resolve the same route over and over.
@orpiske

orpiske commented May 22, 2023

Copy link
Copy Markdown
Contributor Author

@davsclaus @rhuan080 Guys, do you mind sharing your thoughts about this?

Claus had suggested, on the discussion on apache/camel#9972, that the LRUCache was an interesting test scenario. Here I am providing a set of tests that should cover a few of the areas that I believe could be hit by the LRUCache changes.

There are 4 new tests added and they should cover the following aspects:

  • EndpointCreationTest: compute the accumulated time of all the operations required to create a given number of routes (500, in this test).
  • EndpointResolveTest: compute the accumulated time of all the operations required to resolve the same route over and over (this is a rather "macro" operation, so it's not something that would be inlined)
  • EndpointRegistryTest: tests specific operations of the Endpoint registry in single-thread scenarios.
  • EndpointRegistryScalabilityTest: tests specific operations of the Endpoint registry in multi-thread scenarios.

I am currently running the baselines for these (on 4.0 main and 4.0 M1). After that, I'll run it with the changes on apache/camel#10157 to verify the impacts.

Please let me know if you notice something is missing or wrong.

@orpiske
orpiske force-pushed the added-endpoint-tests branch from e0dd66e to 1b382f5 Compare May 22, 2023 13:27
@davsclaus

Copy link
Copy Markdown
Contributor

It may also be interresting to test with camel-caffeine-lrucache on the classpath to use caffeeine as thread-safe cache. Then we can compare this with #10157

Also #10157 can potentially be optimized to only sync on certain situations.

…Registry

- EndpointRegistry: this tests specific operations of the Endpoint registry in single-thread scenarios
- EndpointRegistryScalabilityTest: this tests specific operations of the Endpoint registry in multi-thread scenarios.=
@orpiske
orpiske force-pushed the added-endpoint-tests branch from 1b382f5 to ffab236 Compare May 22, 2023 15:44

@oscerd oscerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we should add the license everywhere in this repo.

@orpiske

orpiske commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

LGTM, I think we should add the license everywhere in this repo.

Indeed! I created a ticket so I don't forget to fix these ... we have quite a couple ones missing the license information.

@orpiske
orpiske marked this pull request as ready for review May 23, 2023 14:19
@orpiske
orpiske merged commit 1376682 into apache:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants