NPE when VM is planned to migrate to other host during dynamic scaling by harikrishna-patnala · Pull Request #3998 · apache/cloudstack

harikrishna-patnala · 2020-03-30T10:55:26Z

Description

NPE occurred when dynamic scaling tried on VM and as part of this when MS tries to migrate VM if current host does not have capacity.

Repro Steps:
1. Create a VM on host1
2. Make host1 capacity full by deploying multiple VMs
3. Try Dynamic scaling on VM on host1
4. NPE occurs when MS tries to find host to migrate the VM and then scale.
2020-03-27 05:37:15,899 WARN [c.c.v.UserVmManagerImpl] (API-Job-Executor-6:ctx-f7c76e69 job-3021 ctx-d68f535a) (logid:3189e554) Received exception while scaling
java.lang.NullPointerException
at com.cloud.deploy.DeploymentPlanningManagerImpl.planDeployment(DeploymentPlanningManagerImpl.java:255)
at com.cloud.vm.VirtualMachineManagerImpl.findHostAndMigrate(VirtualMachineManagerImpl.java:3768)
at com.cloud.vm.UserVmManagerImpl.upgradeRunningVirtualMachine(UserVmManagerImpl.java:1816)
at com.cloud.vm.UserVmManagerImpl.upgradeVirtualMachine(UserVmManagerImpl.java:1702)
at com.cloud.vm.UserVmManagerImpl.upgradeVirtualMachine(UserVmManagerImpl.java:1641)

Root cause: VM profile is not initiated properly with serviceoffering before planning for deployment

Solution: Initiate VM profile with serviceoffering and also make sure custom compute parameters are handled

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

1. Create a VM on host1
2. Make host1 capacity full by deploying multiple VMs
3. Try Dynamic scaling on VM on host1
4. Successfully scaled the VM after migration of VM to host2

harikrishna-patnala · 2020-03-30T11:00:13Z

@blueorangutan package

blueorangutan · 2020-03-30T11:00:37Z

@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-03-30T11:11:07Z

Packaging result: ✖centos7 ✖debian. JID-1105

… VM tries to migrate if current host does not have capacity. Repro Steps: 1. Create a VM on host1 2. Make host1 capacity full by deploying multiple VMs 3. Try Dynamic scaling on VM on host1 4. NPE occurs when MS tries to find host to migrate the VM and then scale. Root cause: VM profile is not initiated properly with serviceoffering before planning for deployment Solution: Iniate VM profile with serviceoffering and also make sure custom compute parameters are handled

harikrishna-patnala · 2020-03-30T14:21:15Z

@blueorangutan package

blueorangutan · 2020-03-30T14:21:38Z

@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-03-30T14:47:31Z

Packaging result: ✔centos7 ✔debian. JID-1106

borisstoyanov · 2020-05-14T10:31:32Z

@blueorangutan package

blueorangutan · 2020-05-14T10:32:06Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-05-14T10:59:33Z

Packaging result: ✔centos7 ✔debian. JID-1225

yadvr · 2020-06-11T12:02:47Z

@blueorangutan package

blueorangutan · 2020-06-11T12:04:05Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-06-11T12:36:31Z

Packaging result: ✔centos7 ✔debian. JID-1349

yadvr · 2020-06-12T04:52:45Z

@blueorangutan test

blueorangutan · 2020-06-12T04:54:18Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2020-06-13T00:36:19Z

@blueorangutan test

blueorangutan · 2020-06-13T00:37:11Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2020-06-16T04:46:55Z

@blueorangutan package

blueorangutan · 2020-06-16T04:47:25Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-06-16T05:48:07Z

Packaging result: ✔centos7 ✖debian. JID-1384

yadvr · 2020-06-16T06:09:01Z

Debian build failure was env related, I'll kick test
@blueorangutan test

blueorangutan · 2020-06-16T06:09:25Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr

LGTM did not test it

yadvr · 2020-06-16T06:12:15Z

After merging #3991, are you LGTM on this as well @borisstoyanov and @DaanHoogland ?

DaanHoogland · 2020-06-16T12:50:09Z

code looks good, but i'm not familiar with the use case / bug; +0.1

harikrishna-patnala · 2020-06-16T13:55:48Z

@rhtyd @DaanHoogland This is not related to #3991. While testing that PR I came across with this bug and fixed it here. This PR is required as NPE is not good in any case.

blueorangutan · 2020-06-17T17:42:01Z

Trillian test result (tid-1750)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52130 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3998-t1750-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	637.84	test_vpc_redundant.py

harikrishna-patnala mentioned this pull request Mar 30, 2020

Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time #3991

Merged

3 tasks

harikrishna-patnala force-pushed the VMScalingNPEwhilefindHostandMigrate branch from 32b4340 to b3cf7b5 Compare March 30, 2020 14:20

svenvogel added type:bug component:management-server labels Apr 1, 2020

yadvr added this to the 4.15.0.0 milestone Jun 4, 2020

yadvr self-requested a review June 12, 2020 04:55

yadvr approved these changes Jun 16, 2020

View reviewed changes

yadvr requested a review from DaanHoogland June 16, 2020 06:11

yadvr requested a review from borisstoyanov June 16, 2020 06:11

yadvr merged commit 0d4f67a into apache:master Jun 18, 2020

Uh oh!

Conversation

harikrishna-patnala commented Mar 30, 2020

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

harikrishna-patnala commented Mar 30, 2020

Uh oh!

blueorangutan commented Mar 30, 2020

Uh oh!

blueorangutan commented Mar 30, 2020

Uh oh!

harikrishna-patnala commented Mar 30, 2020

Uh oh!

blueorangutan commented Mar 30, 2020

Uh oh!

blueorangutan commented Mar 30, 2020

Uh oh!

borisstoyanov commented May 14, 2020

Uh oh!

blueorangutan commented May 14, 2020

Uh oh!

blueorangutan commented May 14, 2020

Uh oh!

yadvr commented Jun 11, 2020

Uh oh!

blueorangutan commented Jun 11, 2020

Uh oh!

blueorangutan commented Jun 11, 2020

Uh oh!

yadvr commented Jun 12, 2020

Uh oh!

blueorangutan commented Jun 12, 2020

Uh oh!

yadvr commented Jun 13, 2020

Uh oh!

blueorangutan commented Jun 13, 2020

Uh oh!

yadvr commented Jun 16, 2020

Uh oh!

blueorangutan commented Jun 16, 2020

Uh oh!

blueorangutan commented Jun 16, 2020

Uh oh!

yadvr commented Jun 16, 2020

Uh oh!

blueorangutan commented Jun 16, 2020

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jun 16, 2020

Uh oh!

DaanHoogland commented Jun 16, 2020

Uh oh!

harikrishna-patnala commented Jun 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Jun 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

harikrishna-patnala commented Jun 16, 2020 •

edited

Loading