Add support to StartTLS on Quota's mailing#4573
Conversation
DaanHoogland
left a comment
There was a problem hiding this comment.
code looks ok, and old behaviour is default, so looks good in that aspect. As a thunderbird user i have the experience that the client can discover what kind of security is used however, can we implement such a thing as well?
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2681 |
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✔centos8 ✖debian. JID-2701 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
1 similar comment
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2756 |
|
Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2757 |
43b3d7c to
2109523
Compare
2109523 to
e08ef1a
Compare
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2878 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 325 |
|
@rhtyd @DaanHoogland is there anything else to do? |
|
Trillian test result (tid-390)
|
Description
On Quota's mailing settings, ACS has a configuration (
quota.usage.smtp.useAuth) to inform if it will use secure SMTP authentication when sending emails.However, this configuration only refers to use SSL or not. Operators haves no option to choose if they want to use StartTLS.
This PR intends to add support to StartTLS on Quota's mailing settings.
It is interesting to highlight that this enhancement would be able to solve issue #2625 (if it was applied in that setting as well); however, to reduce the scope of change, this one focuses only on Quota's mailing configuration.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
It has been tested locally on a test lab.
On
Quota - All Accounts, I added 10 credits to my user and set 20 as min balance.I had added an gmail address to Accounts > <account> > Users - Email.
I allowed
Less secure app accesson my Google account.I had restarted management server.
And I called
quota updateAPI via Cloudmonkey. Without the new option being introduced here, I would see an error in the management server. After setting it, everything is fine, and the alert email is sent.