Improve logs on IpmitoolOutOfBandManagementDriver#4702
Conversation
| import java.util.List; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
| import org.apache.commons.lang3.StringUtils; |
There was a problem hiding this comment.
please use our own (cloudstack) Stringutils as proxy, even when calling the apache.commons
There was a problem hiding this comment.
There is no consensus on that. I would prefer this way, using the library directly. We do not get benefits on a facade like that.
There was a problem hiding this comment.
yes we do, and we are badly hampered in most cases where we don't (gson/logging mostly)
There was a problem hiding this comment.
So, lets add a facade to Spring as well, and to any other utils library that we use :)
I still see no benefits on creating such facades.
There was a problem hiding this comment.
that is a lazy exaggeration, we have a facade for string utils and we are hampered by several 3rd party libraries for which we don't. If there are resources for making such a thing for spring, great. Let's do it.
BTW, in this case I didn't 👎 on this issue, but on other counts I might as well. duckduck "using 3rd party library facades", will give you some wisdom on this.
out
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2881 |
|
@blueorangutan package |
|
@GutoVeronezi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 396 |
|
Re-kicking travis |
|
@rhtyd @GabrielBrascher @DaanHoogland is there anything else to do? |
|
that's a no |
Description
This PR intends to improve logging in the class
IpmitoolOutOfBandManagementDriverto facilitate troubleshooting.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
It has been tested locally on a test lab.