server: allow copy cross-zone templates to other zone

[ustcweizhou]

Description

This PR fixes the issue that cross-zone templates cannot be copied to new zone.

steps to reproduce the issue
(1) register a cross-zone template
(2) when it is done, remote it from http server
(3) create a new zone
(4) template cannot be downloaded to new zone, as it has been removed from http server
(5) copy template from first zone to new zone

Expected result: succeed
Actual result: API succeed, but nothing changed, logs: "Template 300 is cross-zone, don't need to copy"

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[DaanHoogland]

right, that has definately had some heads scratching. clgtm

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

[blueorangutan]

Packaging result: ✔️ centos7 ✖️ centos8 ✔️ debian. SL-JID 151

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests [S]

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 296

[Pearl1594]

@blueorangutan test

[blueorangutan]

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian Build Failed (tid-308)

[Pearl1594]

@blueorangutan test

[blueorangutan]

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[Pearl1594]

Verified behavior. LGTM

[blueorangutan]

Trillian test result (tid-316)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37312 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4804-t316-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestKubernetesCluster>:teardown	Error	79.52	test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume	Error	69.28	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	50.19	test_vm_life_cycle.py