Skip to content

ui: Fix add primary store during Zone Deployment for PreSetup protocol#4845

Merged
yadvr merged 1 commit into
apache:4.15from
shapeblue:fix-zone-depl-primary
Mar 22, 2021
Merged

ui: Fix add primary store during Zone Deployment for PreSetup protocol#4845
yadvr merged 1 commit into
apache:4.15from
shapeblue:fix-zone-depl-primary

Conversation

@Pearl1594

@Pearl1594 Pearl1594 commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

Description

This PR fixes the issue that occurs while adding a primary store using PreSetup protocol during zone deployment for XenServer, where in, it fails to find the primary store path, as, for XenServer we provide the SR Label

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Prior fix:
On firefox:
image

On Chrome:
image

Post Fix:
Successfully deploys the zone
image

@Pearl1594

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

@Pearl1594

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

@Pearl1594 Pearl1594 changed the base branch from master to 4.15 March 19, 2021 14:58
@Pearl1594 Pearl1594 added this to the 4.15.1.0 milestone Mar 19, 2021

@utchoang utchoang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yadvr yadvr merged commit 6262366 into apache:4.15 Mar 22, 2021
DaanHoogland pushed a commit that referenced this pull request Mar 23, 2021
* 4.15:
  ui: Consider overprovisioning factor when displaying allocated progress bar (#4850)
  ui: Fix the styles action button (#4856)
  ui: Fill out the search filter form field after performing a filter (#4855)
  ui: fix add cluster form for vmware (#4841)
  ui: Fix add primary store during Zone Deployment for PreSetup protocol (#4845)
  tests: Extend wait time after interrupt (#4815)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants