Skip to content

ui: assignVM: Set isrecursive to false when fetching accounts#4867

Merged
yadvr merged 2 commits into
apache:4.15from
shapeblue:fix-assign-instance
Apr 1, 2021
Merged

ui: assignVM: Set isrecursive to false when fetching accounts#4867
yadvr merged 2 commits into
apache:4.15from
shapeblue:fix-assign-instance

Conversation

@davidjumani

@davidjumani davidjumani commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

Description

Fixes the issue of displaying users in subdomains as well
Broken in the old UI as well

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

@davidjumani davidjumani added this to the 4.15.1.0 milestone Mar 25, 2021
@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4867 (SL-JID-74)

@utchoang utchoang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yadvr

yadvr commented Mar 29, 2021

Copy link
Copy Markdown
Member

@davidjumani what is the issue - how do we reproduce and test the fix?

@davidjumani

Copy link
Copy Markdown
Contributor Author

@rhtyd The issue is that calling list accounts with listall=true returns accounts in sub domains as well, even when isrecursive is set to false, related #4868
This PR replaces listall with isrecursive=false so that accounts belonging to the specific domain are returned

As admin -> assign VM -> Root domain. Users from the subdomains are also listed. Selecting a user from the sub domain leads to an error
Screenshot from 2021-03-30 10-04-56

@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4867 (SL-JID-79)

@yadvr yadvr merged commit fd4bc61 into apache:4.15 Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants