ui: Show diskoffering for create volume from ROOT volume snaps#4912
Merged
Conversation
Contributor
Author
|
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
fdalsotto
reviewed
Apr 12, 2021
| dataView: true, | ||
| show: (record) => { return record.state === 'BackedUp' }, | ||
| args: ['snapshotid', 'name'], | ||
| args: (record, store) => { |
|
UI build: ✔️ |
Member
|
@davidjumani is that for master branch only, or is it a bugfix that 4.15 can have as well? |
Contributor
|
@davidjumani changed the base branch. Please update if wrong cc @rhtyd |
utchoang
approved these changes
Apr 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue of not being able to select the diskofferingid while creating volumes from snapshots of ROOT volumes
Types of changes
Bug Severity
Screenshots (if appropriate):