Skip to content

UI: Search view - Fixes the color style of the filter icon#4917

Merged
yadvr merged 2 commits into
apache:4.15from
utchoang:feature/fix-style-icon-filter
Apr 13, 2021
Merged

UI: Search view - Fixes the color style of the filter icon#4917
yadvr merged 2 commits into
apache:4.15from
utchoang:feature/fix-style-icon-filter

Conversation

@utchoang

@utchoang utchoang commented Apr 13, 2021

Copy link
Copy Markdown

Description

Fixes the color style of the filter icon

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

BEFORE:
image
image

AFTER:
image
image

How Has This Been Tested?

@utchoang utchoang changed the base branch from master to 4.15 April 13, 2021 07:11
@utchoang

Copy link
Copy Markdown
Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4917 (SL-JID-97)

@yadvr

yadvr commented Apr 13, 2021

Copy link
Copy Markdown
Member

@utchoang would this not be in blue colour if some search query is already set - for example, somebody searching but then the form is not displayed, would have the icon turned blue? (for ex. with refresh and pages/navigation)

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Blue icon when filtering is active
Screenshot from 2021-04-13 18-00-22
Even when form is not displaying
Screenshot from 2021-04-13 18-02-27

Normal icon when no filtering
Screenshot from 2021-04-13 18-00-31

@shwstppr shwstppr added this to the 4.15.1.0 milestone Apr 13, 2021
@yadvr

yadvr commented Apr 13, 2021

Copy link
Copy Markdown
Member

I think I didn't get that, so the fix is to ensure the style is enforced when filtering is used.

@yadvr

yadvr commented Apr 13, 2021

Copy link
Copy Markdown
Member

Merging based on @shwstppr 's testing and review, and my review.

@yadvr yadvr merged commit 6200ac8 into apache:4.15 Apr 13, 2021
@utchoang utchoang deleted the feature/fix-style-icon-filter branch April 14, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants