Skip to content

UI: Disabled root disk size customization if Service Offering has a fixed size#4933

Merged
yadvr merged 1 commit into
apache:4.15from
utchoang:feature/disabled-custom-root-disk-size
Apr 20, 2021
Merged

UI: Disabled root disk size customization if Service Offering has a fixed size#4933
yadvr merged 1 commit into
apache:4.15from
utchoang:feature/disabled-custom-root-disk-size

Conversation

@utchoang

@utchoang utchoang commented Apr 19, 2021

Copy link
Copy Markdown

Description

Fixes #4930

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image
image

How Has This Been Tested?

@utchoang

Copy link
Copy Markdown
Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4933 (SL-JID-101)

@utchoang utchoang requested review from shwstppr, wido and yadvr April 19, 2021 03:04
@wido wido requested a review from GabrielBrascher April 19, 2021 08:17

@wido wido left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the quick fix!

@GabrielBrascher GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works perfectly. Thanks, @utchoang!
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants