Skip to content

cloudian: Set cloudian.connector.enabled as not dynamic #4938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 1 commit into from
Apr 21, 2021
Merged

cloudian: Set cloudian.connector.enabled as not dynamic #4938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...integrations/cloudian/src/main/java/org/apache/cloudstack/cloudian/CloudianConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
public interface CloudianConnector extends PluggableService {

ConfigKey<Boolean> CloudianConnectorEnabled = new ConfigKey<>("Advanced", Boolean.class, "cloudian.connector.enabled", "false",
"If set to true, this enables the Cloudian Connector for CloudStack.", true);
"If set to true, this enables the Cloudian Connector for CloudStack.", false);

@yadvr yadvr Apr 20, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidjumani this won't work - maybe for UI but for the plugin to instantiate - you'll need to restart mgmt server, as it's used in the configure method of manager/class

@davidjumani davidjumani Apr 21, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly why it's being set as non dynamic. The user will get a notification that the MS needs to be restarted after this change and on restart it'll pick up the necessary API

@yadvr yadvr Apr 21, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, my bad I misunderstood - lgtm.


ConfigKey<String> CloudianAdminHost = new ConfigKey<>("Advanced", String.class, "cloudian.admin.host", "s3-admin.cloudian.com",
"The hostname of the Cloudian Admin server.", true);
Expand Down