Skip to content

ui: fix select networks for template nic#5933

Merged
sureshanaparti merged 2 commits into
apache:4.16from
shapeblue:fix-ui-nicnetworkselection
Feb 7, 2022
Merged

ui: fix select networks for template nic#5933
sureshanaparti merged 2 commits into
apache:4.16from
shapeblue:fix-ui-nicnetworkselection

Conversation

@shwstppr

@shwstppr shwstppr commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

Description

Fixes #5927

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2022-02-04 14-40-04

Screenshot from 2022-02-04 14-40-26

How Has This Been Tested?

Fixes apache#5927

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

shwstppr commented Feb 4, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5933 (SL-JID-1091)

@DaanHoogland

Copy link
Copy Markdown
Contributor

testing this will require a real vmware host, so
@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2453

@DaanHoogland

Copy link
Copy Markdown
Contributor

testing this will require a real vmware host, so @blueorangutan package

confusing @shwstppr 's PRs . this one doesn't need a real vmware host

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2456

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

shwstppr commented Feb 7, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@shwstppr shwstppr marked this pull request as ready for review February 7, 2022 05:55
@sureshanaparti

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5933 (SL-JID-1102)

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2480

@sureshanaparti

Copy link
Copy Markdown
Contributor

@blueorangutan test centos7 vmware-67u3

@blueorangutan

Copy link
Copy Markdown

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@shwstppr

shwstppr commented Feb 7, 2022

Copy link
Copy Markdown
Contributor Author

Purely UI changes so I'm not sure if smoke test results will catch any errors

@sureshanaparti

Copy link
Copy Markdown
Contributor

Purely UI changes so I'm not sure if smoke test results will catch any errors

correct, will validate the changes in the env. no need to check the smoke tests.

@yadvr yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM needs manual testing

@DaanHoogland

Copy link
Copy Markdown
Contributor

@sureshanaparti @rohityadavcloud this one has been confusing me, We don't need smoke tests but we do need a real vmware env to test this. A simulated environment like Qa.... won't let us do the action needed on a vmware template.

@sureshanaparti sureshanaparti self-assigned this Feb 7, 2022

@Pearl1594 Pearl1594 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified fix. LGTM.

@utchoang utchoang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sureshanaparti

sureshanaparti commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

@shwstppr Networks section also shows only last 10 (in the scroll), please check. No issues in the nic drop down list.

@sureshanaparti

Copy link
Copy Markdown
Contributor

@shwstppr Networks section also shows only last 10 (in the scroll), please check. No issues in the nic drop down list.

confused due to page size, could see all networks in the subsequent pages. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

[UI][VMware][Deploy-as-is] - Drop down does not show all networks

7 participants