reject non-BMP code points in the Character type converter#425
Open
digi-scrypt wants to merge 1 commit into
Open
reject non-BMP code points in the Character type converter#425digi-scrypt wants to merge 1 commit into
digi-scrypt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked the code point is in the BMP before the cast and throw otherwise, so the value is rejected at conversion instead of quietly truncated. Have we considered that a char simply cannot hold an astral code point? Added a parameterized case for \u1F600 next to the existing \u0124 one.