perf: optimize spark_lpad (up to 2x faster) - #4919
Merged
andygrove merged 1 commit intoJul 15, 2026
Merged
Conversation
spark_lpad (up to 2x faster)
andygrove
marked this pull request as ready for review
July 14, 2026 14:09
comphead
reviewed
Jul 14, 2026
| let mut data_capacity = 0usize; | ||
| let mut max_length = 0usize; | ||
| for length in int_pad_array.values() { | ||
| let length = (*length).max(0) as usize; |
Contributor
There was a problem hiding this comment.
Hopefully this every row cast is not expensive on modern CPUs
andygrove
deleted the
auto-opt/spark_lpad-datafusion-comet-20260714-051345
branch
July 15, 2026 20:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Optimize existing expression.
What changes are included in this PR?
Pad rows with one memcpy from a precomputed repeating pad buffer and write pieces directly into the string builder instead of a scratch String, plus an ASCII fast path and a fix for a rows*rows capacity hint in the column-length path.
How are these changes tested?
Existing tests + new unit tests.
Benchmark (criterion):
Full criterion output: