Removed Arc wrapping for AggregateFunctionExpr - #12353
Merged
Merged
Conversation
athultr1997
marked this pull request as draft
September 6, 2024 07:30
athultr1997
force-pushed
the
athultr/remove_arc_agg_func_expr
branch
from
September 6, 2024 07:41
461e842 to
62aa914
Compare
athultr1997
force-pushed
the
athultr/remove_arc_agg_func_expr
branch
from
September 6, 2024 07:42
62aa914 to
901e87e
Compare
athultr1997
marked this pull request as ready for review
September 6, 2024 07:43
Contributor
|
Thanks @athultr1997 -- this looks really neat |
alamb
approved these changes
Sep 7, 2024
alamb
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me -- thank you @athultr1997
cc @lewiszlw
I am also going to mark this PR as an API change as I think several of the functions are pub
lewiszlw
approved these changes
Sep 7, 2024
lewiszlw
left a comment
Member
There was a problem hiding this comment.
LGTM. Thank you @athultr1997.
Contributor
|
🚀 |
Contributor
|
Thanks again @athultr1997 and @jayzhan211 and @lewiszlw for the reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12257.
Rationale for this change
The trait
AggregateFunctionExprwas removed previously in #12096 . This is a follow-up PR that removes the usage of Arc wrapping forAggregateFunctionExpr.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?