Unify Metadata Handing: use FieldMetadata in Expr::Alias and ExprSchemable - #16320
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FieldMetadatastructure #16317Rationale for this change
We are working metadata through DataFusion as part of supporting extension types
so having a single unified representation to work on will make the code easier
to do. I added
FieldMetadatato avoid the use ofBTreeMapdirecectly, but foundthere were still places that used
HashMapto pass metadata around directlyWhat changes are included in this PR?
Let's use FieldMetadata everywhere
Are these changes tested?
By CI
Are there any user-facing changes?
This is an API change, but I think it sets us up for unified and efficient metadata handling in DataFusion