refactor: Move SMJ tests into own file - #17495
Merged
Merged
Conversation
Contributor
Author
|
cc @alamb |
jonathanc-n
commented
Sep 9, 2025
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| //! SortMergeJoin Testing Module |
Contributor
Author
There was a problem hiding this comment.
Added this to let developers know what tests are currently added
findepi
approved these changes
Sep 10, 2025
findepi
left a comment
Member
There was a problem hiding this comment.
Verified this is pure code move with any incidental changes.
xudong963
approved these changes
Sep 10, 2025
Contributor
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Comment: #17431 (comment)_
Rationale for this change
SMJ tests have a lot of lines of code split into its own module