Migrate ExplainExec and AnalyzeExec protobuf serde - #23742
Merged
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23742 +/- ##
========================================
Coverage 80.69% 80.69%
========================================
Files 1090 1090
Lines 370357 370485 +128
Branches 370357 370485 +128
========================================
+ Hits 298859 298963 +104
- Misses 53684 53696 +12
- Partials 17814 17826 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Phoenix500526
force-pushed
the
issue/23511
branch
from
July 24, 2026 00:50
7388aea to
0595e12
Compare
Contributor
|
Please resolve conflicts 🙏🏻 |
Move ExplainExec serialization into its execution plan implementation. This removes its live central dispatch while preserving the existing wire format and deprecated compatibility entry points. Add roundtrip coverage for every StringifiedPlan variant and all stored ExplainExec fields. Refs apache#23511 Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
Move AnalyzeExec serialization into its execution plan implementation. This removes its live central dispatch while preserving the existing wire format and deprecated compatibility entry points. Strengthen roundtrip coverage for the child plan, schema, flags, metric categories, and explain format. Closes apache#23511 Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
Phoenix500526
force-pushed
the
issue/23511
branch
from
July 25, 2026 02:02
0595e12 to
a02a5a7
Compare
Contributor
Author
Done |
adriangb
approved these changes
Jul 25, 2026
adriangb
enabled auto-merge
July 25, 2026 02:18
kosiew
pushed a commit
to kosiew/datafusion
that referenced
this pull request
Aug 12, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#23511. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Physical plan protobuf serialization is being moved from the central dispatch module into each `ExecutionPlan` implementation. Co-locating this logic with the corresponding execution plan makes the serialization code easier to maintain and incrementally reduces the central downcast chain. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> - Implement plan-local protobuf serialization and deserialization for `ExplainExec`. - Implement plan-local protobuf serialization and deserialization for `AnalyzeExec`. - Remove both plans from the live central serialization dispatch. - Retain the deprecated compatibility methods as delegates to the new implementations. - Preserve the existing protobuf wire format. - Strengthen roundtrip tests to cover all stored fields, including every `StringifiedPlan` variant, metric categories, and explain formats. Each execution plan migration is kept in a separate commit. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes. The following checks pass: - `cargo fmt --all` - `cargo clippy --all-targets --all-features -- -D warnings` - Full extended workspace test suite - `cargo test -p datafusion-proto --test proto_integration` The proto integration suite passes all 209 tests after rebasing onto the latest `main`. ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> No. This is an internal refactor and does not change the protobuf wire format or user-facing behavior. --------- Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Physical plan protobuf serialization is being moved from the central
dispatch module into each
ExecutionPlanimplementation. Co-locatingthis logic with the corresponding execution plan makes the serialization
code easier to maintain and incrementally reduces the central downcast
chain.
What changes are included in this PR?
ExplainExec.AnalyzeExec.implementations.
StringifiedPlanvariant, metric categories, and explain formats.Each execution plan migration is kept in a separate commit.
Are these changes tested?
Yes. The following checks pass:
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo test -p datafusion-proto --test proto_integrationThe proto integration suite passes all 209 tests after rebasing onto the
latest
main.Are there any user-facing changes?
No. This is an internal refactor and does not change the protobuf wire
format or user-facing behavior.