Skip to content

bench: pwmj right semi/anti existence joins - #24458

Merged
neilconway merged 3 commits into
apache:mainfrom
SubhamSinghal:bench-pwmj-right-existence
Aug 19, 2026
Merged

bench: pwmj right semi/anti existence joins#24458
neilconway merged 3 commits into
apache:mainfrom
SubhamSinghal:bench-pwmj-right-existence

Conversation

@SubhamSinghal

@SubhamSinghal SubhamSinghal commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

RightSemi/RightAnti range joins plan as NestedLoopJoinExec today, and the existence-join
benchmark added in #24160 does not cover them, so there is no way to say what routing them PiecewiseMergeJoinExec would be worth — before or after such a change lands.

This benchmark runs on either side of it: the pwmj_enabled arm accepts whichever operator the build plans and prints it, so a run on main today is a valid NestedLoopJoinExec baseline that a later build compares straight against.

What changes are included in this PR?

Bench code only, all in datafusion/core/benches/pwmj_semi_anti_sql.rs:

  • RIGHT SEMI / RIGHT ANTI cases across the same three match regimes as the existing ones, written out as joins rather than reached through EXISTS (a decorrelated EXISTS gives LeftSemi, and which side a nested-loop join marks is its own choice, so a subquery cannot pin these join types).
  • One bench_case runner shared by every case, replacing the previous inline per-case plumbing, driven by a Kind enum with one variant per JoinType. Adding the mark joins later is two more variants rather than a new code path.

Are these changes tested?

The guards above are the tests

Are there any user-facing changes?

No. Benchmark code only.

@codecov-commenter

codecov-commenter commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.23%. Comparing base (54355e1) to head (c6e5c9c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24458      +/-   ##
==========================================
- Coverage   81.23%   81.23%   -0.01%     
==========================================
  Files        1113     1113              
  Lines      392521   392521              
  Branches   392521   392521              
==========================================
- Hits       318867   318860       -7     
- Misses      54902    54903       +1     
- Partials    18752    18758       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@neilconway

Copy link
Copy Markdown
Contributor

@SubhamSinghal Can you fix the clippy issues, please?

@SubhamSinghal

SubhamSinghal commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

resolved clippy error but [Detect breaking changes / Check semver (pull_request)] is running from a long time.

@neilconway neilconway left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@neilconway
neilconway added this pull request to the merge queue Aug 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 19, 2026
@neilconway
neilconway added this pull request to the merge queue Aug 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 19, 2026
@neilconway
neilconway added this pull request to the merge queue Aug 19, 2026
Merged via the queue into apache:main with commit d5cf4f6 Aug 19, 2026
36 of 37 checks passed
@SubhamSinghal
SubhamSinghal deleted the bench-pwmj-right-existence branch August 20, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants