Skip to content

Improve join type support in substrait - #5051

Merged
alamb merged 1 commit into
apache:masterfrom
andygrove:substrait-join-type
Jan 24, 2023
Merged

Improve join type support in substrait#5051
alamb merged 1 commit into
apache:masterfrom
andygrove:substrait-join-type

Conversation

@andygrove

@andygrove andygrove commented Jan 24, 2023

Copy link
Copy Markdown
Member

Which issue does this PR close?

Part of #4897

Original PR: https://github.com/datafusion-contrib/datafusion-substrait/pull/38/files

Rationale for this change

Re-applying PR from datafusion-substrait repo

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@andygrove

Copy link
Copy Markdown
Member Author

@nseekhao

@github-actions github-actions Bot added the substrait Changes to the substrait crate label Jan 24, 2023
@andygrove andygrove mentioned this pull request Jan 24, 2023
5 tasks

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb
alamb merged commit c947b05 into apache:master Jan 24, 2023
@ursabot

ursabot commented Jan 24, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = e30711d and contender = c947b05. c947b05 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@andygrove
andygrove deleted the substrait-join-type branch January 27, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants