Skip to content

Docs: Add query syntax to COPY docs - #7388

Merged
alamb merged 3 commits into
apache:mainfrom
alamb:alamb/dml_better
Aug 24, 2023
Merged

Docs: Add query syntax to COPY docs#7388
alamb merged 3 commits into
apache:mainfrom
alamb:alamb/dml_better

Conversation

@alamb

@alamb alamb commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Part of #7319

Rationale for this change

One thing I noticed while reviewing #7362 (thank you @spaydar !!) was that it didn't mention the COPY (SELECT ...) syntax, which is quite helpful for reordering input, for example.

What changes are included in this PR?

Add note and example of using COPY (SELECT ...) and define what DDL/DML are

Are these changes tested?

Are there any user-facing changes?

better docs

@alamb
alamb marked this pull request as ready for review August 23, 2023 17:50
@alamb alamb mentioned this pull request Aug 23, 2023
@alamb alamb changed the title Docs: Add query syntax to COPY docs Docs: Add query syntax to COPY docs Aug 23, 2023

@spaydar spaydar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- pointed out a subtle mistake in the COPY syntax spec and a couple typos

Comment thread docs/source/user-guide/sql/ddl.md Outdated
Comment thread docs/source/user-guide/sql/dml.md Outdated
Comment thread docs/source/user-guide/sql/dml.md Outdated
Co-authored-by: Seth Paydar <29551413+spaydar@users.noreply.github.com>
@alamb

alamb commented Aug 24, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @spaydar for saving me (again) from silly typos

@alamb
alamb merged commit 50b1fac into apache:main Aug 24, 2023
@alamb
alamb deleted the alamb/dml_better branch August 24, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants