Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Query provider metadata for the current service using its mesh, interface, version, and group, then resolve
ProviderAppName. Generate the Service Trace dashboard URL withvar-application=<ProviderAppName>andvar-service=<Interface>only when the provider application is unique and reliable.Return an error if metadata lookup fails, metadata is absent, the application is missing, or multiple distinct applications are found. Multiple metadata entries with the same application are deduplicated. The fix does not arbitrarily select the first provider or rely on Grafana's saved default. Service Metric URL construction is unchanged, and Go regression tests cover the behavior.
Changed files:
pkg/console/service/observability.gopkg/console/handler/observability.gopkg/console/service/observability_test.goBranch:
fix/service-trace-dashboard-variables. Commit:fdc0179af46efae89711af2dfe8186e461d41e5d(fix: provide application for service trace dashboard).Related issues
Fixes #1568
Related to #1524
Verification
go test ./pkg/console/service ./pkg/console/handler: PASS.For Service Trace, the variables generated by Dubbo Admin were used in a live Grafana/Jaeger query that returned the newly generated trace. Instance Metric retains its existing
IP:QoSPortsemantics. Instance Trace has a separate known issue and is not changed by this PR.The external end-to-end verifier sends a real
/loginrequest and finds itsUserService/logintrace in Jaeger. It then calls Dubbo Admin's Trace dashboard API, reads the actual URL and live Grafana dashboard query template, and executes the Grafana Jaeger query using Admin's variables. It reports PASS only if the query returns the same new trace ID.Impact