Conversation
|
Author
|
我已经在本地基于当前这个 PR,实现了后续的 D003 Kubernetes Observability provisioning(Kubernetes 可观测性配置) 改动。 D003 中 Admin 使用的 Dashboard URL 依赖于 D002 引入的、修正后的 Grafana Service DNS。因此,将 D003 暂时叠加在当前 PR 之上,可以保留这个前置依赖,同时避免重复实现 D002 中已经完成的修复。 目前,静态 provisioning 检查已经通过;运行时验证仍然尚未完成。 等 D002 合并之后,我会把 D003 rebase 到更新后的 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fixes #1570.
This PR addresses three Kubernetes deployment-manifest correctness issues:
Namespace/dubbo-systembefore the resources that use it.nodePortfields from the NacosClusterIPService.The change is contained in one commit,
cafc748bd51c730c7e1b9f2cdc135f8aed14667c(fix: correct Kubernetes deployment manifests), and three files underrelease/kubernetes/dubbo-system/.Changes
release/kubernetes/dubbo-system/00-namespace.yamlto definedubbo-system. The filename places the Namespace beforedubbo-admin.yamlandnacos.yamlwhen applying the directory withkubectl apply -f release/kubernetes/dubbo-system.ClusterIP, preserving itsportandtargetPortvalues while removingnodePort: 30848andnodePort: 31848. Its internal service address is unchanged.http://grafana.monitoringg.svc:3000tohttp://grafana.monitoring.svc:3000, matching the included Grafana Service.Validation
git diff --check: PASS.dubbo-systemnamespaced resource), B1 (valid NacosClusterIPfields), B2 (Kubernetes server-side dry-run), and C (Grafana DNS). Before the filename correction it reported A1 PASS, A2 FAIL, B1/B2/C PASS; after the correction, all five checks PASS. A2 evaluates the actual file order rather than requiring a particular filename.kubectl apply --dry-run=client -f release/kubernetes/dubbo-system -o namelists the Namespace before the Dubbo Admin and Nacos resources.A disposable Kubernetes cluster was not available, so a real fresh-cluster Deployment Smoke Test has not been performed. This PR does not claim that full deployment verification passed.
Scope
This PR does not change dashboard provisioning, Jaeger datasource setup, OTel Collector, Instance/Service Trace queries, log observability, or cross-signal navigation.
Areas affected