Skip to content

fix: detect fractional-second AM/PM date formats - #1119

Open
nkuprins wants to merge 1 commit into
apache:mainfrom
nkuprins:fix/ampm-fractional-second-date-format
Open

nkuprins wants to merge 1 commit into
apache:mainfrom
nkuprins:fix/ampm-fractional-second-date-format

Conversation

@nkuprins

Copy link
Copy Markdown
Contributor

Closed: #1118

Purpose of the pull request

As title.

What's changed?

  • Added the missing optional space to date_ptrn3b in ExcelDateFormatDetector, matching POI.
  • Added a hh:mm:ss.000 AM/PM case to DateUtilsTest.test_isADateFormat_true.

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@bengbengbalabalabeng

Copy link
Copy Markdown
Contributor

LGTM.

NOTE: This change will be merged after the current release is completed. We'll follow up and push the merge forward once the release is done.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Date format with fractional seconds and AM/PM is read as a raw serial

2 participants