fix(server): retry all PD peers while waiting for storage - #3129
Open
bitflicker64 wants to merge 1 commit into
Open
fix(server): retry all PD peers while waiting for storage#3129bitflicker64 wants to merge 1 commit into
bitflicker64 wants to merge 1 commit into
Conversation
9 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes wait-storage.sh behavior in multi-PD HStore deployments by avoiding “pinning” to the first PD that answers /v1/health, and instead probing store readiness (/v1/stores) across all configured PD REST peers until any peer reports an Up store. This improves Server startup robustness when some PD peers are listening but not yet raft-ready.
Changes:
- Update
wait-storage.shto retry/v1/storesacross every configured PD peer on each retry cycle and succeed as soon as any peer reports"state":"Up". - Add a deterministic shell regression test suite that mocks
curl,sleep, andtimeoutto validate failover / retry behavior. - Add a dedicated GitHub Actions job to run the new shell regression suite in CI.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
hugegraph-server/hugegraph-dist/src/assembly/static/bin/wait-storage.sh |
Removes /v1/health gating and probes /v1/stores across all PD peers per retry, succeeding on the first peer that reports an Up store. |
hugegraph-server/hugegraph-dist/src/assembly/travis/test-wait-storage.sh |
Adds deterministic, mocked shell tests covering peer order, retry/failover, and timeout behavior. |
.github/workflows/server-ci.yml |
Adds a CI job that runs the new test-wait-storage.sh regression suite. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
wait-storage.shselected the first PD answering/v1/health, then polled/v1/storesonly on that peer. Since the health endpoint can succeed beforethe peer has raft-backed store state, a storeless first peer could block Server
startup even when another configured PD already reported an
Upstore.Main Changes
/v1/storesacross every configured PD peer on every retry.Up, without a separate/v1/healthselection stage.timing, and the existing outer timeout failure.
Verifying these changes
test-wait-storage.sh: 4 scenarios passed, 0 failed.bash -npassed for the production and test scripts.git diff --checkpassed.Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No NeedOut of scope
wait-partition.sh