Skip to content

fix(table): validate snapshot timestamp drift#3443

Closed
GayathriSrividya wants to merge 4 commits into
apache:mainfrom
GayathriSrividya:fix/issue-2938-snapshot-timestamp-validity
Closed

fix(table): validate snapshot timestamp drift#3443
GayathriSrividya wants to merge 4 commits into
apache:mainfrom
GayathriSrividya:fix/issue-2938-snapshot-timestamp-validity

Conversation

@GayathriSrividya

Copy link
Copy Markdown
Contributor

Rationale

Align snapshot timestamp validation with the Java and Rust implementations by rejecting timestamps that drift backwards by more than one minute. Small clock skew remains allowed.

This also validates parsed table metadata:

  • snapshot-log entries remain sorted within the one-minute tolerance
  • last-updated-ms is not more than one minute behind the latest snapshot-log entry

Attribution

This revives the implementation from #3062 by @mrutunjay-kinagi. I cherry-picked the original authored commits onto the latest main, preserving authorship, and am reopening it because the earlier PR was closed automatically after inactivity. It includes the metadata-level validation added in response to @Fokko's review.

Verification

  • make lint
  • make test (3713 passed, 1534 deselected)

@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Jun 30, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants