Skip to content

fix(consensus): keep a late retry's reply instead of refusing it - #3945

Merged
hubcio merged 12 commits into
masterfrom
fix_late_reply
Aug 27, 2026
Merged

fix(consensus): keep a late retry's reply instead of refusing it#3945
hubcio merged 12 commits into
masterfrom
fix_late_reply

Conversation

@numinnex

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 21, 2026
@numinnex

Copy link
Copy Markdown
Contributor Author

Merge after #3944

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.40659% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.20%. Comparing base (ffb186d) to head (28035ad).

Files with missing lines Patch % Lines
core/consensus/src/client_table.rs 93.25% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #3945       +/-   ##
=============================================
- Coverage     84.20%   68.20%   -16.00%     
  Complexity     1398     1398               
=============================================
  Files          1219     1218        -1     
  Lines        173564   154236    -19328     
  Branches     140662   121335    -19327     
=============================================
- Hits         146153   105201    -40952     
- Misses        23449    45119    +21670     
+ Partials       3962     3916       -46     
Components Coverage Δ
Rust Core 64.45% <93.40%> (-20.57%) ⬇️
Java SDK 67.23% <ø> (ø)
C# SDK 75.41% <ø> (+0.02%) ⬆️
Python SDK 90.06% <ø> (ø)
PHP SDK 85.65% <ø> (ø)
Node SDK 96.07% <ø> (ø)
Go SDK 69.09% <ø> (ø)
Files with missing lines Coverage Δ
core/consensus/src/metadata_helpers.rs 94.03% <100.00%> (+0.01%) ⬆️
core/consensus/src/client_table.rs 90.06% <93.25%> (+0.11%) ⬆️

... and 305 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread core/integration/tests/cluster/client_table_adversarial.rs
Comment thread core/consensus/src/client_table.rs
Comment thread core/consensus/src/client_table.rs Outdated
Comment thread core/integration/tests/cluster/client_table_adversarial.rs
@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Aug 27, 2026

@hubcio hubcio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more that lands on a line outside the diff, so leaving it here:

encode_decode_roundtrip_preserves_dedup_state (core/consensus/src/client_table.rs:3044) builds a 3-deep ring, so the new transferable_replies() cap is exercised by nothing - shipping 0, 5, or the whole ring would all pass. commit more than REPLY_RING_CAPACITY replies, encode/decode, then assert exactly the newest 5 replay and the 6th-newest draws AlreadyApplied. that's also the concrete test for the transfer guarantee question on line 1720.

Comment thread core/consensus/src/client_table.rs Outdated
Comment thread core/consensus/src/client_table.rs Outdated
@numinnex

Copy link
Copy Markdown
Contributor Author

/ready

@github-actions github-actions Bot added S-waiting-on-review PR is waiting on a reviewer and removed S-waiting-on-author PR is waiting on author response labels Aug 27, 2026
@hubcio
hubcio merged commit 9c6451d into master Aug 27, 2026
97 checks passed
@hubcio
hubcio deleted the fix_late_reply branch August 27, 2026 12:27
@github-actions github-actions Bot removed the S-waiting-on-review PR is waiting on a reviewer label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants