fix(consensus): keep a late retry's reply instead of refusing it - #3945
Merged
Conversation
Contributor
Author
|
Merge after #3944 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3945 +/- ##
=============================================
- Coverage 84.20% 68.20% -16.00%
Complexity 1398 1398
=============================================
Files 1219 1218 -1
Lines 173564 154236 -19328
Branches 140662 121335 -19327
=============================================
- Hits 146153 105201 -40952
- Misses 23449 45119 +21670
+ Partials 3962 3916 -46
🚀 New features to boost your workflow:
|
numinnex
force-pushed
the
fix_late_reply
branch
from
August 24, 2026 08:04
0be79b0 to
c7eae7b
Compare
numinnex
force-pushed
the
fix_late_reply
branch
from
August 24, 2026 08:50
c7eae7b to
b92b501
Compare
numinnex
force-pushed
the
fix_late_reply
branch
from
August 27, 2026 09:15
9be104a to
4825666
Compare
spetz
requested changes
Aug 27, 2026
hubcio
requested changes
Aug 27, 2026
hubcio
left a comment
Contributor
There was a problem hiding this comment.
one more that lands on a line outside the diff, so leaving it here:
encode_decode_roundtrip_preserves_dedup_state (core/consensus/src/client_table.rs:3044) builds a 3-deep ring, so the new transferable_replies() cap is exercised by nothing - shipping 0, 5, or the whole ring would all pass. commit more than REPLY_RING_CAPACITY replies, encode/decode, then assert exactly the newest 5 replay and the 6th-newest draws AlreadyApplied. that's also the concrete test for the transfer guarantee question on line 1720.
Contributor
Author
|
/ready |
spetz
approved these changes
Aug 27, 2026
hubcio
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.