[KYUUBI #7615] Move engine application manager info configuration to the start method - #7616
Open
wForget wants to merge 2 commits into
Open
[KYUUBI #7615] Move engine application manager info configuration to the start method#7616wForget wants to merge 2 commits into
wForget wants to merge 2 commits into
Conversation
…on to the start method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Closes #7615.
ProcBuilderinitializes the engine application manager information during trait construction. ForSparkProcessBuilder, this invokesappMgrInfo(), which eventually evaluatesdefaultsConfbefore the subclass fieldsparkHomehas been initialized.At that point,
sparkHomeis stillnull, so the path tospark-defaults.confis resolved incorrectly anddefaultsConfis cached as an empty map. Consequently,spark.mastercannot be loaded fromspark-defaults.conf, causing Kyuubi to select the wrong cluster manager.This patch moves the engine application manager information initialization to
ProcBuilder#start, where the process builder has been fully initialized.How was this patch tested?
Added a unit test and manually verified that the Spark engine starts successfully when
spark.masteris configured inspark-defaults.conf.Was this patch authored or co-authored using generative AI tooling?
No