fix: restore Ollama Cloud thinking options - #1010
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the Ollama Cloud thinking-option derivation accidentally reverted by #1005. Active reasoning models again expose the provider-supported effort values; GPT-OSS remains limited to low/medium/high, while deprecated and non-reasoning models remain excluded.
This restores GLM-5.2's
/thinkingcontrols andthinking:defaultTUI status. The failures recorded in #1008 were not render-timing flakes: the merge ref included #1005, so GLM-5.2 had no thinking variants and the expected status could never render.Closes #1008.
Verification
npm --workspace @maka/core testnpm --workspace @maka/runtime testnpm --workspace maka-agent testnpm run typecheck