Skip to content

fix(desktop): route Codex OAuth through active proxy - #1302

Merged
Astro-Han merged 1 commit into
apache:mainfrom
iMLe0n:codex/fix-codex-oauth-proxy
Jul 21, 2026
Merged

fix(desktop): route Codex OAuth through active proxy#1302
Astro-Han merged 1 commit into
apache:mainfrom
iMLe0n:codex/fix-codex-oauth-proxy

Conversation

@iMLe0n

@iMLe0n iMLe0n commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • route Codex OAuth authorization-code exchange and token refresh through Maka active-proxy-aware fetch
  • preserve injected fetch implementations for tests and callers
  • update the regression contract so the service cannot silently fall back to Electron global fetch

Closes #1301

Verification

  • npm --workspace @maka/desktop test — 2752 passed, 0 failed
  • npm --workspace @maka/desktop run typecheck
  • npm --workspace @maka/runtime run typecheck
  • npx biome lint on both changed files
  • focused Codex OAuth tests with coverage — 13 passed; helper coverage 89.39% lines / 82.50% branches / 80% functions
  • Electron run-as-node local proxy probe — proxyHit true, HTTP 200

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Astro-Han
Astro-Han merged commit c319690 into apache:main Jul 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codex OAuth token exchange bypasses the configured proxy

2 participants