fix(ui): clarify the Usage page hierarchy - #2024
Conversation
|
Could you rebase onto current main? The branch base is 47 commits behind, and the e2e failure is the sidebar rename spec (sidebar-navigation.spec.ts:72), which races without the #2022 fix (2e30bd8) that landed after this branch forked. Not caused by this PR. Review is done and it is a pass with no blocking findings: the padding bleed is correctly root-caused (the Astryx table wrapper inherits |
4406e98 to
ab79d84
Compare
|
Rebased as requested. The previously failing sidebar rename shard now passes, and all CI checks are green. |
Summary
The Usage page already rendered its controls and tables with Astryx primitives, but it still bypassed the shared Settings page rhythm. Its table also inherited the outer layout padding variables, so the Astryx scroll wrapper bled roughly 24 px outside the intended data region and visually collapsed into the tabs above it.
This PR:
Closes #1903
中文说明
使用统计页虽然已经使用 Astryx 的控件与表格,但页面根仍未接入统一的 Settings 页面节奏。表格还会继承外层布局的 padding 变量,使 Astryx 的滚动容器向上、向左右越界约 24 px,视觉上与上方 Tabs 挤成同一条区域。
本 PR 将页面接入共享 SettingsPage,把范围/摘要与 Tabs/当前数据集分成两个层级;有数据时由 Astryx Card 提供明确的数据表面边界,列宽、滚动、密度、分隔线和行语义仍由 Astryx Table 负责。原有范围切换、刷新、筛选、详情开关和会话跳转行为不变,并补齐空状态、单供应商、多模型、长内容和窄窗口 Storybook 场景。
Verification
Review focus
The Card around a populated table is the Astryx container boundary, not a second table implementation. It resets the inherited container-padding variables that caused the scroll wrapper to bleed outside the Usage panel; Table remains the sole owner of table geometry and semantics.